[Bug 733265] srtpenc: remove get-rollover-counter signal and add stats property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=733265

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329597|none                        |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 329597:
 --> (https://bugzilla.gnome.org/review?bug=733265&attachment=329597)

Makes sense, yes

::: ext/srtp/gstsrtpenc.c
@@ +617,3 @@
+    while (stream) {
+      GstStructure *ss;
+      guint32 ssrc = ntohl (stream->ssrc);

You probably want to use GUINT32_FROM_BE() or something here, or g_ntohl() at
least.

@@ +630,3 @@
+  }
+
+  gst_structure_set_value (s, "streams", &va);

gst_structure_take_value()?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.