[Bug 767553] qmlgisink: Fix cannot create egl context on wayland

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun Jun 12 08:06:49 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=767553

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329631|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 329631:
 --> (https://bugzilla.gnome.org/review?bug=767553&attachment=329631)

::: ext/qt/qtitem.cc
@@ +33,3 @@
 #include <QtQuick/QQuickWindow>
 #include <QtQuick/QSGSimpleTextureNode>
+#include <QtGui/5.6.1/QtGui/qpa/qplatformnativeinterface.h>

This should work as #include <QtGui/gpa/...>. You will have to set up things
correctly in configure.ac for that

@@ +160,3 @@
+    QPlatformNativeInterface *native =
+              QGuiApplication::platformNativeInterface();
+    ret = (GstGLDisplayWayland *)g_object_new (GST_TYPE_GL_DISPLAY_WAYLAND,
NULL);

Why don't we have a gst_gl_display_wayland_new()? Might make sense to add :)

@@ +162,3 @@
+    ret = (GstGLDisplayWayland *)g_object_new (GST_TYPE_GL_DISPLAY_WAYLAND,
NULL);
+    ret->display = (struct wl_display *)
+              native->nativeResourceForWindow("display", NULL);

And that could take this in the constructor

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list