[Bug 767553] qmlglsink: Add Wayland support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767553

--- Comment #4 from Haihua Hu <jared.hu at nxp.com> ---
(In reply to Sebastian Dröge (slomo) from comment #2)
> Review of attachment 329631 [details] [review]:
> 
> ::: ext/qt/qtitem.cc
> @@ +33,3 @@
>  #include <QtQuick/QQuickWindow>
>  #include <QtQuick/QSGSimpleTextureNode>
> +#include <QtGui/5.6.1/QtGui/qpa/qplatformnativeinterface.h>
> 
> This should work as #include <QtGui/gpa/...>. You will have to set up things
> correctly in configure.ac for that
> 

But I cannot found gpa folder in QtGui, it cannot work on my side. What should
i set in configure.ac?

> @@ +160,3 @@
> +    QPlatformNativeInterface *native =
> +              QGuiApplication::platformNativeInterface();
> +    ret = (GstGLDisplayWayland *)g_object_new (GST_TYPE_GL_DISPLAY_WAYLAND,
> NULL);
> 
> Why don't we have a gst_gl_display_wayland_new()? Might make sense to add :)
> 

gst_gl_display_wayland_new() will use wl_display_connect to get wayland
display. It is not correct on wayland for qt implement. 

> @@ +162,3 @@
> +    ret = (GstGLDisplayWayland *)g_object_new (GST_TYPE_GL_DISPLAY_WAYLAND,
> NULL);
> +    ret->display = (struct wl_display *)
> +              native->nativeResourceForWindow("display", NULL);
> 
> And that could take this in the constructor

It is just for qtsink, not compatible for other GL plugin

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.