[Bug 767402] OpenJPEG decoder: use new sampling field to determine channel order for j2c and jpc streams

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767402

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329639|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 329639:
 --> (https://bugzilla.gnome.org/review?bug=767402&attachment=329639)

::: ext/openjpeg/gstopenjpegdec.c
@@ +208,3 @@
   }

+  if ((sampling = gst_structure_get_string (s, "sampling"))) {

Should we add sampling instead of colorspace to the caps? A parser can always
be used.

Alternatively we should warn below if sampling is not provided because
everything else is guesswork then

@@ +224,3 @@
   }

+  self->sampling = gst_structure_get_string (s, "sampling");

You need to g_strdup() here. The returned string is only valid as long as you
have a strong reference to the structure

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.