[Bug 730539] sdp: add support for multiple crypto sessions

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jun 13 07:03:19 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=730539

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329661|none                        |reviewed
             status|                            |

--- Comment #17 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 329661:
 --> (https://bugzilla.gnome.org/review?bug=730539&attachment=329661)

Looks mostly good now, thanks

::: gst/rtsp-server/rtsp-sdp.c
@@ +156,3 @@
+      }
+
+      gst_mikey_message_add_cs_srtp (msg, 0, ssrc, roc);

If roc == -1, shouldn't we error out completely instead of adding -1 to the
SDP?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.


More information about the gstreamer-bugs mailing list