[Bug 730539] sdp: add support for multiple crypto sessions

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jun 13 18:20:39 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=730539

--- Comment #18 from Aleix Conchillo Flaqué <aconchillo at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #17)
> Review of attachment 329661 [details] [review]:
> 
> Looks mostly good now, thanks
> 
> ::: gst/rtsp-server/rtsp-sdp.c
> @@ +156,3 @@
> +      }
> +
> +      gst_mikey_message_add_cs_srtp (msg, 0, ssrc, roc);
> 
> If roc == -1, shouldn't we error out completely instead of adding -1 to the
> SDP?

Do you mean propagating the error or just GST_ERROR? For error propagation I'll
have to change a few more functions.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.


More information about the gstreamer-bugs mailing list