[Bug 766184] Video distortion with VAAPI when using tee element

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766184

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329719|accepted-commit_now         |reviewed
             status|                            |

--- Comment #14 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 329719:
 --> (https://bugzilla.gnome.org/review?bug=766184&attachment=329719)

::: gst/vaapi/gstvaapivideobufferpool.c
@@ +184,3 @@
+            GST_VIDEO_INFO_PLANE_OFFSET (&new_vip, i) !=
+            GST_VIDEO_INFO_PLANE_OFFSET (alloc_vip, i))
+          need_video_meta = TRUE;

what about a break statement after true?

@@ +185,3 @@
+            GST_VIDEO_INFO_PLANE_OFFSET (alloc_vip, i))
+          need_video_meta = TRUE;
+      }

I feel that it would be better to move this check after the allocator is set,
and to use  priv->alloc_vip and priv->video_info

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.