[Bug 767176] vaapiencode: implement flush() vmethod

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767176

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329754|accepted-commit_now         |needs-work
             status|                            |

--- Comment #16 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Comment on attachment 329754
  --> https://bugzilla.gnome.org/attachment.cgi?id=329754
vaapiencode: implement flush vmethod on vaapiencode

Sorry. I spoke too fast. The patch is not 100% good.

According to the documentation the flush vmethod: flushes all remaining data
from the encoder *without pushing it downstream*

And your patch is pushing the frames to downstream, so the flow_ret could have
different values to GST_FLOW_OK leading to the same deadlock.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.