[Bug 767176] vaapiencode: implement flush() vmethod

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767176

--- Comment #24 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 329894:
 --> (https://bugzilla.gnome.org/review?bug=767176&attachment=329894)

::: gst/vaapi/gstvaapiencode.c
@@ +624,3 @@
+  GST_VIDEO_ENCODER_STREAM_LOCK (encode);
+  GST_VIDEO_ENCODER_STREAM_LOCK (encode);
+

Yep, this code is very wrong. To implement flush, you often need to implement a
FLUSH_START handler. Make sure you understand all blocking operation in your
encoder, and then make sure that in that handler you unblock all those.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.