[Bug 767645] Unallocated memory access in OpenGlSurfacePainter

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767645

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329776|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 329776:
 --> (https://bugzilla.gnome.org/review?bug=767645&attachment=329776)

In general getting the strides, offsets, etc should be done with the
GstVideoInfo and/or GstVideoFrame API. That will always give you the correct
values and you don't have to implement the conversions yourself.

::: elements/gstqtvideosink/delegates/qtvideosinkdelegate.cpp
@@ +108,3 @@
             GstMapInfo mem_info;
             if (gst_buffer_map(m_buffer, &mem_info, GST_MAP_READ)) {
+                m_painter->paint(mem_info.data, gst_buffer_get_size(m_buffer),
m_bufferFormat,

You can use mem_info.size here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.