[Bug 767402] OpenJPEG decoder: use new sampling field to determine channel order for j2c and jpc streams

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767402

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329815|none                        |needs-work
             status|                            |

--- Comment #17 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 329815:
 --> (https://bugzilla.gnome.org/review?bug=767402&attachment=329815)

Just one minor thing left :)

::: ext/openjpeg/gstopenjpegdec.c
@@ +205,3 @@
   }

+  self->sampling = g_strdup (gst_structure_get_string (s, "sampling"));

As you g_strdup() this, you will have to free the string when needed (i.e. when
shutting down and when set_format is called another time).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.