[Bug 755329] Race condition around finish_unprepare

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755329

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #311737|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 311737:
 --> (https://bugzilla.gnome.org/review?bug=755329&attachment=311737)

Makes sense but does not seem complete yet :) Can you update?

Also please attach it as a "git format-patch" style patch with a proper commit
message explaining what happens when and why

Thanks!

::: gst/rtsp-server/rtsp-media.c
@@ +1890,3 @@
         finish_unprepare (media);
       }
+      g_rec_mutex_unlock (&priv->state_lock);

Locking should be needed for the other messages too then with the same
reasoning

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.