[Bug 767429] vtdec: Renegotiation from GL to sysmem to GL with playbin

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Jun 21 06:21:39 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=767429

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330115|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330115:
 --> (https://bugzilla.gnome.org/review?bug=767429&attachment=330115)

This is more a optimization for vtdec (and other hardware decoders should
probably do the same), to keep the codec setup overhead lower and not do
unneeded re-setups :)

::: sys/applemedia/vtdec.c
@@ +242,2 @@
   peercaps = gst_pad_peer_query_caps (GST_VIDEO_DECODER_SRC_PAD (vtdec),
NULL);
+  if (gst_caps_is_any (peercaps) && prevcaps) {

This should probably check if the peercaps still are a superset of our current
caps, instead of special casing ANY.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list