[Bug 767857] leaks tracer: list alive objects on demande and add 'checkpointing' support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767857

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330051|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330051:
 --> (https://bugzilla.gnome.org/review?bug=767857&attachment=330051)

::: plugins/tracers/gstleaks.c
@@ +165,3 @@
   self->objects = g_hash_table_new (NULL, NULL);
+
+  instances = g_list_append (instances, self);

You probably want to use a GQueue here, for nicer API and O(1) append :)

@@ +366,3 @@
+
+  if (g_getenv ("GST_LEAKS_TRACER_SIG")) {
+    signal (SIGUSR1, sig_usr1_handler);

This probably has to be put into some #ifdefs and corresponding configure
checks, also you need to #include signal.h?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.