[Bug 765807] dvdlpcmdec: rewrite with GstAudioDecoder and add new format

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765807

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #327021|none                        |reviewed
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 327021:
 --> (https://bugzilla.gnome.org/review?bug=765807&attachment=327021)

Generally looks good, thanks! Good work

::: gst/dvdlpcmdec/gstdvdlpcmdec.c
@@ +544,3 @@
   channels = GST_AUDIO_INFO_CHANNELS (&dvdlpcmdec->info);

+  gst_buffer_ref (buf);

Why? Please make sure it is unreffed in all cases, but this seems unnecessary?
The base class keeps track of that for you

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.