[Bug 766993] Android decodebin: zero copy between hardware decoder and glimagesink doesn't work (regression in 1.9)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766993

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #58 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Pushed a slightly modified version (only debugging).

commit d3f3787d64bd0adb56bd2052e733e61f10f55acf
Author: Matthew Waters <matthew at centricular.com>
Date:   Wed Jun 15 12:47:05 2016 +1000

    glsl: fixup external-oes shaders by mangling the required extension

    Newer devices require using a different GLSL extension for accessing
    external-oes textures in a shader using the texture() functions.

    While the GL_OES_EGL_image_external_essl3 should supposedly be supported
    on a any GLES3 android device, the extension was defined after a lot of the
    older drivers were built so they will not know about it.  Thus there are
two
    possible interpretations of which of texture[2D]() should be supported for
    external-oes textures.  Strict adherence to the GL_OES_EGL_image_external
    extension spec which uses texture2D() or following GLES3's pattern, also
    allowing texture() as a function for accessing external-oes textures

    This adds another mangling pass to convert
     #extension GL_OES_EGL_image_external : ...
    into
     #extension GL_OES_EGL_image_external_essl3 : ...
    on GLES3 and when the GL_OES_EGL_image_external_essl3 extension is
supported.

    Only uses texture() when the GLES3 and the GL_OES_EGL_image_external_essl3
    extension is supported for external-oes textures.
    Uses GLES2 + texture2D() + GL_OES_EGL_image_external in all other
external-oes
    cases.

    https://bugzilla.gnome.org/show_bug.cgi?id=766993

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.