[Bug 765600] memory: add gst_memory_try_map() or new GstMapFlags to silence GST_ERROR

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765600

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330143|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330143:
 --> (https://bugzilla.gnome.org/review?bug=765600&attachment=330143)

::: gst/gstmemory.c
@@ +343,3 @@
+ * @flags: mapping flags
+ *
+ * Same as gst_memory_map() except that it does not log an error on failure.

Maybe we shouldn't make this too explicit. We might want to add a vfunc for
that to GstMemory later that does things differently for example. That it just
does the same except for the error logging seems not too useful.

Not sure how to write that though

@@ +344,3 @@
+ *
+ * Same as gst_memory_map() except that it does not log an error on failure.
+ */

Since: 1.10

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.