[Bug 765927] new plugin: ICC (International Color Consortium) correction plugin

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765927

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #327420|none                        |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 327420:
 --> (https://bugzilla.gnome.org/review?bug=765927&attachment=327420)

This should probably be a GstMeta or custom sticky event, GstMeta seems more
correct

::: ext/libpng/gstpngdec.c
@@ +358,3 @@
+
+    if (ret & PNG_INFO_iCCP) {
+      icc_result = malloc (icc_proflen);

g_malloc() or even better g_new() :)

@@ +387,3 @@
+        taglist = gst_tag_list_new_empty ();
+        gst_tag_list_add (taglist, GST_TAG_MERGE_APPEND, GST_TAG_ATTACHMENT,
+            tagsample, NULL);

gst_video_decoder_merge_tags() if you use tags, otherwise you override other
tags. But this does not seem like the job for a tag.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.