[Bug 767934] vaapidecoder_h265: critical memory leak

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767934

sreerenj <bsreerenj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED

--- Comment #7 from sreerenj <bsreerenj at gmail.com> ---
(In reply to Hyunjun Ko from comment #4)
> (In reply to Víctor Manuel Jáquez Leal from comment #2).
> > Review of attachment 330174 [details] [review] [review]:
> > 
> > H264 and H265 decoders are very similar, and in H264 is not failing, if I
> > understand correctly. Why is happening only in H265?
> > 
> > ::: gst-libs/gst/vaapi/gstvaapidecoder_h265.c
> > @@ -747,3 @@
> >    if (hard_flush) {
> > -    for (i = 0; i < priv->dpb_count; i++)
> > -      dpb_remove_index (decoder, i);
> > 
> > The question is, why dpb_remove_index() is not working as expected? why do
> > we need another function?
> 
> The one thing that I could say is the logic below is not doing to remove all
> pictures
> > - for (i = 0; i < priv->dpb_count; i++)
> > -      dpb_remove_index (decoder, i);

You are right :), wonder why did't hit issues till now !!
I will push the patch after few other verification, thanks!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.