[Bug 767900] multipartmux is not clearing dts timestamp.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767900

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330189|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330189:
 --> (https://bugzilla.gnome.org/review?bug=767900&attachment=330189)

Generally looks like going in the right direction, thanks :)

::: gst/multipart/multipartmux.c
@@ +318,2 @@
   /* no timestamp on new buffer, it must go first */
+  newtime = new->pts_timestamp;

All this should probably use the DTS of both, and only if there is not DTS on
both fall back to PTS. Should also use the running time, not the buffer
timestamp

@@ +357,3 @@

+      /* Store timestamps with segment_start and preroll */
+      if (buf && GST_BUFFER_PTS_IS_VALID (buf) && GST_BUFFER_DTS_IS_VALID
(buf)) {

Set PTS if PTS is valid, DTS if DTS is valid. No need to only set both if both
are valid

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.