[Bug 767908] jpeg2000parse: use enums for colorspace and sampling, rather than strings

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Jun 23 07:05:58 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=767908

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330207|none                        |needs-work
             status|                            |

--- Comment #19 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330207:
 --> (https://bugzilla.gnome.org/review?bug=767908&attachment=330207)

Looks good to me now except for one small thing :)

::: gst-libs/gst/codecparsers/gstjpeg2000sampling.h
@@ +26,3 @@
+
+/**
+* Sampling values from RF 5371 for JPEG 2000 over RTP :
https://datatracker.ietf.org/doc/rfc5371/C

Please make this a proper gtk-doc comment, and also document all other public
functions and enums. Functions in .c, everything else in .h

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list