[Bug 767950] qtmux: Add support for writing timecode track

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767950

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330196|none                        |reviewed
             status|                            |

--- Comment #2 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 330196:
 --> (https://bugzilla.gnome.org/review?bug=767950&attachment=330196)

Looks overall good, just one minor issue found.

::: gst/isomp4/atoms.c
@@ +2115,3 @@
+    prop_copy_uint8 (tmcd->name.string_length, buffer, size, offset);
+    prop_copy_uint8 (tmcd->name.language_code, buffer, size, offset);
+    prop_copy_fixed_size_string ((guint8 *)tmcd->name.name,
tmcd->name.string_length, buffer, size, offset);

You would need to also write this atom's size here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.