[Bug 767862] leaks tracer: display creation stack trace of leaked objects

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767862

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330270|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330270:
 --> (https://bugzilla.gnome.org/review?bug=767862&attachment=330270)

::: configure.ac
@@ +810,3 @@
+
+if test "x$HAVE_UNWIND" = "xyes"; then
+AC_DEFINE(HAVE_UNWIND, 1, [libunwind available])

Indentation

::: plugins/tracers/gstleaks.c
@@ +34,3 @@

+#ifdef HAVE_UNWIND
+#define UNW_LOCAL_ONLY

What does this do?

@@ +194,3 @@
+    name[0] = '\0';
+    if (unw_get_proc_name (&cursor, name, 256, &offp) != 0)
+      break;

This might be cut off here and the last byte might not be '\0', right? In which
case you need to make it that.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.