[Bug 767512] jpeg2000parse: support j2c and jp2 file formats

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767512

Luis de Bethencourt <luis at debethencourt.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |luis at debethencourt.com

--- Comment #48 from Luis de Bethencourt <luis at debethencourt.com> ---
There is something here that looks strange:

+      /* check for missing contiguous code stream box size */
+      if (j2c_box_id_offset < GST_JPEG2000_PARSE_SIZE_OF_J2C_BOX_SIZE) {
+        GST_ELEMENT_ERROR (jpeg2000parse, STREAM, DECODE, NULL,
+            ("Missing contiguous code stream box size for j2c stream"));
+        ret = GST_FLOW_ERROR;
+        goto beach;
+      }
+
+      /* check that we have enough bytes for the J2C box size */
+      if (j2c_box_id_offset < GST_JPEG2000_PARSE_SIZE_OF_J2C_BOX_SIZE) {
+        *skipsize = gst_byte_reader_get_size (&reader) - num_prefix_bytes;
+        goto beach;
+      }


These two checks are identical, but shouldn't be.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.