[Bug 768161] impossible for application to set GstVaapiDisplay/x11 display with vaapipostproc/vaapisink with gst_parse_launch()

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768161

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330542|none                        |reviewed
             status|                            |

--- Comment #3 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 330542:
 --> (https://bugzilla.gnome.org/review?bug=768161&attachment=330542)

::: gst/vaapi/gstvaapipostproc.c
@@ +945,2 @@
   /* Append raw video caps */
+  if (GST_VAAPI_PLUGIN_BASE (postproc)->display) {

Thanks!

I would set an else block to add the raw caps in the template:

raw_caps =  gst_caps_from_string (GST_VIDEO_CAPS_MAKE (GST_VIDEO_FORMATS_ALL)
", "
      GST_CAPS_INTERLACED_MODES);

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.