[Bug 742922] vaapidecode: support reverse playback

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Jun 30 14:42:42 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=742922

--- Comment #32 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 328781:
 --> (https://bugzilla.gnome.org/review?bug=742922&attachment=328781)

::: gst/vaapi/gstvaapidecode.c
@@ +538,3 @@
+      && !GST_VIDEO_CODEC_FRAME_IS_SYNC_POINT (out_frame)) {
+    GST_DEBUG_OBJECT (decode, "drop frame in reverse playback");
+    gst_video_decoder_drop_frame (GST_VIDEO_DECODER (decode), out_frame);

Oh, I forgot, in my opinion we should use here gst_video_decoder_relese_frame,
because we don't want a QoS message, just silently discard this frame:

https://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-base-libs/html/gst-plugins-base-libs-GstVideoDecoder.html#gst-video-decoder-drop-frame

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list