[Bug 768178] tagdemux: Drops data of too small files in PUSH mode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768178

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |t.i.m at zen.co.uk
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.9.1

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Thanks for the bug report. This fixes it for me:

commit a2c050a4beaa7ec92eaf30ee6ac644e3de7dcaf3
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Thu Jun 30 18:53:07 2016 +0100

    tagdemux: fix handling of very short files in push mode

    By default we'll wait for a certain amount of data before
    attempting typefinding. However, if the stream is fairly
    short, we might get EOS before we ever attempted any
    typefinding, so at this point we should force typefinding
    and output any pending data if we manage to detect the
    type.

    https://bugzilla.gnome.org//show_bug.cgi?id=768178

commit 130e78dbd8ac2a11f8f8f0c293d1193ad639c2bf
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Thu Jun 30 17:30:34 2016 +0100

    tagdemux: fix erroring out if we reach EOS without detecting type

    In 0.10 the source pad was a dynamic pad that was only added once
    the type had been detected, but in 1.x it's an always source pad,
    so checking whether it's still NULL won't work to detect if the
    type has been detected.

    Makes tagdemux error out when we get EOS but haven't managed to
    identify the format of the data after the tag.

    https://bugzilla.gnome.org//show_bug.cgi?id=768178


We might still want some minimum threshold on typefind probability or so in
this case, but we can fix that later as needed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.