[Bug 756806] message: Add extra information fields to error/warning/info messages

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756806

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #322843|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 322843:
 --> (https://bugzilla.gnome.org/review?bug=756806&attachment=322843)

::: gst/gstelement.c
@@ +1904,3 @@
       break;
     case GST_MESSAGE_INFO:
+      message = gst_message_new_info (GST_OBJECT_CAST (element), gerror,
sent_debug);   // TODO

Should get the same message API for warning/info messages

::: gst/gstelement.h
@@ +409,3 @@
  * application will be requested to stop further media processing.
  */
+#define GST_ELEMENT_ERROR_DATA(el, domain, code, text, debug, args...)  \

ERROR_WITH_DETAILS() maybe?

@@ +417,3 @@
   if (__dbg)                                                            \
     GST_WARNING_OBJECT (el, "error: %s", __dbg);                        \
+  gst_element_message_full_data (GST_ELEMENT(el), GST_MESSAGE_ERROR,    \

And message_full_with_details()?

::: gst/gstmessage.c
@@ +441,3 @@
+/**
+ * gst_message_error_set_details:
+ * @message: (transfer none): The message object

No transfer annotations needed for the instance

@@ +461,3 @@
+ * gst_message_parse_error_details:
+ * @message: (transfer none): The message object
+ * Returns: (transfer none): The details structure

Isn't this function transfer full as you implemented it? And the "Returns: "
line should be below the docs

@@ +468,3 @@
+ */
+GstStructure *
+gst_message_parse_error_details (GstMessage * message)

Elsewhere we use an out parameter for the return values. Seems a bit
inconsistent

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.