[Bug 762988] jitterbuffeR: Performance improvements

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Mar 2 13:53:50 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=762988

--- Comment #3 from Edward Hervey <bilboed at bilboed.com> ---
Created attachment 322859
  --> https://bugzilla.gnome.org/attachment.cgi?id=322859&action=edit
jitterbuffer: Speed up lost timeout handling

When downstream blocks, "lost" timers are created to notify the
outgoing thread that packets are lost.

The problem is that for high packet-rate streams, we might end up with
a big list of lost timeouts (had a use-case with ~1000...).

The problem isn't so much the amount of lost timeouts to handle, but
rather the way they were handled. All timers would first be iterated,
then the one selected would be handled ... to re-iterate the list again.

All of this is being done while the jbuf lock is taken, which in some use-cases
would return in holding that lock for 10s... blocking any buffers from
being accepted in input... which would then arrive late ... which would
create plenty of lost timers ... which would cause the same issue.

In order to avoid that situation, handle the lost timers immediately when
iterating the list of pending timers. This modifies the complexity from
a combinatorial to a linear complexity.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list