[Bug 762986] videoscale: Add option for navigation events to scale and respect internal region without borders

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762986

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #322851|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 322851:
 --> (https://bugzilla.gnome.org/review?bug=762986&attachment=322851)

Makes sense, ideally can you also provide a unit test? There should already be
one that is testing navigation events, would just have to be extended a bit.

::: gst/videoscale/gstvideoscale.c
@@ +1114,3 @@
+              gst_structure_set (structure, "pointer_x", G_TYPE_DOUBLE,
+                  ((a - videoscale->borders_w / 2) * filter->in_info.width /
+                      (filter->out_info.width - videoscale->borders_w)),
NULL);

This one degenerates into the one below for borders_w == 0. So maybe just have
a single gst_structure_set() here :) Should simplify the code a bit

@@ +1127,3 @@
+              gst_structure_set (structure, "pointer_y", G_TYPE_DOUBLE,
+                  ((a - videoscale->borders_h / 2) * filter->in_info.height /
+                      (filter->out_info.height - videoscale->borders_h)),
NULL);

Same here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.