[Bug 762988] rtpjitterbuffer: Performance improvements

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Mar 2 16:23:32 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=762988

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #322859|none                        |reviewed
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 322859:
 --> (https://bugzilla.gnome.org/review?bug=762988&attachment=322859)

It's quadratic to linear complexity, right? At least for the case of LOST
timers... for other timers it can still be quadratic.

::: gst/rtpmanager/gstrtpjitterbuffer.c
@@ +3477,3 @@
       }
     }
     if (timer && !priv->blocked) {

It might make sense to add an assertion that do_timeout() is never called with
LOST anymore. because if it is, your code is wrong

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list