[Bug 762529] v4l2src produces wrong colorimetry info for NV12

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762529

Josep Torra Valles <n770galaxy at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #321976|needs-work                  |none
             status|                            |
 Attachment #321976|0                           |1
        is obsolete|                            |

--- Comment #8 from Josep Torra Valles <n770galaxy at gmail.com> ---
Created attachment 322908
  --> https://bugzilla.gnome.org/attachment.cgi?id=322908&action=edit
Use V4L2 macros to deal with default values on colorimetry related attributes

Cleaned switch as per review request.

But I'm not sure if for V4L2_COLORSPACE_RAW we should directly return in the
case.

Also the value V4L2_COLORSPACE_DEFAULT isn't handled in the switch case
explicitly which might be wrong. In the header there's the following macro and
I'm not sure if we should use it or replicate the behaviour. 

/*
 * Determine how COLORSPACE_DEFAULT should map to a proper colorspace.
 * This depends on whether this is a SDTV image (use SMPTE 170M), an
 * HDTV image (use Rec. 709), or something else (use sRGB).
 */
#define V4L2_MAP_COLORSPACE_DEFAULT(is_sdtv, is_hdtv) \
        ((is_sdtv) ? V4L2_COLORSPACE_SMPTE170M : \
         ((is_hdtv) ? V4L2_COLORSPACE_REC709 : V4L2_COLORSPACE_SRGB))

This logic seems a bit wrong to me, what happens with UDTV ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.