[Bug 763059] gstopusdec: plug caps-leak

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Mar 3 19:59:29 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=763059

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
 Attachment #323019|none                        |needs-work
             status|                            |

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 323019
  --> https://bugzilla.gnome.org/attachment.cgi?id=323019
patch

Thanks, I don't think this is entirely correct though.

The code here might modify the caps via the gst_structure_set_value() in the
loop, and we have no guarantee that we are allowed to modify these caps here.

I think the right solution is to use caps = gst_caps_make_writable (caps) here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list