[Bug 762910] onvifparse: extract and apply onvif timestamp

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762910

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #322727|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 322727:
 --> (https://bugzilla.gnome.org/review?bug=762910&attachment=322727)

This shouldn't be the default, it will break playback unless a) basetime of the
pipeline is 0 and b) the pipeline uses a clock the returns UNIX time (e.g. the
real-time system clock).

::: gst/onvif/gstrtponvifparse.c
@@ +122,3 @@
+  self->last_onvif_timestamp =
+      timestamp_seconds * GST_SECOND + timestamp_nseconds * GST_NSECOND -
+      (2208988800LL * GST_SECOND);

Question is also: why convert to UNIX time? You don't know what your pipeline
clock is using, it might very well use NTP times.

@@ +148,3 @@
+    }
+    if (GST_CLOCK_TIME_IS_VALID (buf->pts)) {
+      buf->pts = self->last_onvif_timestamp;

GST_BUFFER_PTS (buf) = ...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.