[Bug 689460] Can't playback LPCM data via HTTP after playing back something else

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=689460

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #323002|none                        |needs-work
             status|                            |

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 323002:
 --> (https://bugzilla.gnome.org/review?bug=689460&attachment=323002)

This looks like you want to run gst-indent over the .c files.

::: gst/rawparse/gstL16parse.c
@@ +42,3 @@
+
+
+G_DEFINE_TYPE (GstL16Parse, gst_L16_parse, GST_TYPE_BIN)

Probably gst-indent after adding a ; at the end of the line here

@@ +85,3 @@
+      gst_element_factory_make ("audioparse", "L16_inner_parser");
+  if (L16_parse->inner_parser == NULL)
+    return;

You can make this an assertion. It should always work.

@@ +88,3 @@
+
+  g_object_set (G_OBJECT (L16_parse->inner_parser),
+      "format", (gint) 0,

The enums are in the same plugin, so use them :)

@@ +187,3 @@
+
+      gst_query_parse_caps (query, &filter);
+      caps = gst_pad_get_pad_template_caps (GST_PAD (pad));

Get the downstream caps (downstream of audioparse I guess) intersected with
your template caps, and only if there is no downstream use the template caps
instead.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.