[Bug 763065] androidmedia: assorted refactoring

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763065

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #323036|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 323036:
 --> (https://bugzilla.gnome.org/review?bug=763065&attachment=323036)

::: sys/androidmedia/gst-android-hardware-camera.c
@@ +2223,3 @@
         org_freedesktop_gstreamer_androidmedia_gstahccallback.constructor,
         *((jlong *) & cb), *((jlong *) & user_data));
+    if (err)

You're leaking the GError here (and probably want to use its content for
logging at least?)

@@ +2260,3 @@
       android_hardware_camera_camerainfo.klass,
       android_hardware_camera_camerainfo.constructor);
+  if (err)

Same

@@ +2413,3 @@
         org_freedesktop_gstreamer_androidmedia_gstahccallback.constructor,
         *((jlong *) & cb), *((jlong *) & user_data));
+    if (err)

Same

@@ +2443,3 @@
         org_freedesktop_gstreamer_androidmedia_gstahccallback.constructor,
         *((jlong *) & cb), *((jlong *) & user_data));
+    if (err)

Same

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.