[Bug 763165] qtdemux: Seeking in push mode broken

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763165

--- Comment #17 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Gregoire from comment #16)
> Man, how do you do that??? :-) I know it's your project but how do you find
> a bisect in seconds?

git bisect master..1.6.0 -- gst/isomp4
and then running through that step by step until it tells me the offending
commit. Only knowledge needed here is that the problem is in
gst-plugins-good/gst/isomp4 and that it worked in 1.6.0 :) And you need a
testcase

> What is push mode? And why don't I get all the good memos about critical
> changes and new features? ;-)

This one is a bug, not really a critical change or new feature :) A bugfix for
something else that caused a new bug.

Push mode is when the source (or upstream in general) gives you buffers one
after another at its own pace (and block size). Pull mode is when downstream
(the demuxer usually) asks upstream (the source usually) for buffers from a
specific offset with a specific size.

> Anyway, reverting 2dbc9f86fce28f7f06205b6668d568e754b89ba9 fixes the problem
> on my Android system. I can now seek in both directions.

Thanks for confirming

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.