[Bug 709826] mpegtsmux: performance issue

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=709826

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #315849|none                        |needs-work
             status|                            |

--- Comment #25 from Edward Hervey <bilboed at bilboed.com> ---
Review of attachment 315849:
 --> (https://bugzilla.gnome.org/review?bug=709826&attachment=315849)

::: gst/mpegtsmux/mpegtsmux.c
@@ +322,3 @@
+
+  pool_config = gst_buffer_pool_get_config (mux->pool);
+  gst_buffer_pool_config_set_params (pool_config, NULL, 188, 7, 0);

As mentionned in other comments, don't hardcode 188, but instead use the needed
size.

Also, make sure it's reconfigured when the setting changes (it might have a
default of 188, but later be reconfigured to 192 or 204)

Like that you can also use the pool for other output sizes.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.