[Bug 756806] message: Add extra information fields to error/warning/info messages

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756806

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #322964|none                        |needs-work
             status|                            |

--- Comment #5 from Edward Hervey <bilboed at bilboed.com> ---
Review of attachment 322964:
 --> (https://bugzilla.gnome.org/review?bug=756806&attachment=322964)

* Make sure symbols are added to win32/def file (make update-exports)

::: gst/gstelement.h
@@ +860,3 @@
+                                                         const gchar *
function, gint line,
+                                                         const char *name,
...);
+

This should have a G_GNUC_NULL_TERMINATED;

::: gst/gstmessage.c
@@ +208,3 @@
+    case GST_MESSAGE_WARNING:
+    case GST_MESSAGE_INFO:
+      if (gst_structure_has_field_typed (GST_MESSAGE_STRUCTURE (message),

Why do we need to special-case the freeing of the "details" structure ?

Doesn't it automatically get freed when the messages structure is freed ?

@@ +415,3 @@
  * Returns: (transfer full): the new error message.
  *
+ * Since: 1.8

1.10. It's too late for new feature addition in 1.8

@@ +480,3 @@
+ * gst_message_parse_error_details:
+ * @message: (transfer none): The message object
+ * @structure: (transfer none): A pointer to the returned details structure

structure needs (out callee-allocates) annotation. It's a return value, and it
will return a copy. Might want to specify user should free it after usage.
Same applies to other methods

::: tests/check/gst/gstmessage.c
@@ +47,3 @@
     error = g_error_new (domain, 10, "test error");
     fail_if (error == NULL);
+    d = gst_structure_new ("title", "test-field", G_TYPE_STRING,

Can you make this an "additional" test (at the end of the function for
example), so that we check both usages ? i.e. the error message with and
without details.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.