[Bug 763338] funnel: add 'forward-sticky-events-mode' property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763338

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #323435|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 323435:
 --> (https://bugzilla.gnome.org/review?bug=763338&attachment=323435)

::: plugins/elements/gstfunnel.c
@@ +118,3 @@
+  GstFunnelPad *pad = GST_FUNNEL_PAD_CAST (gobject);
+
+  g_slist_free_full (pad->events_sent, (GDestroyNotify) gst_event_unref);

These should be cleared in PAUSED->READY already

@@ +369,3 @@
+{
+  GstFunnelPad *funnelpad = GST_FUNNEL_PAD_CAST (sinkpad);
+  gboolean ret = FALSE;

You probably want to return TRUE if mode==NEVER

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.