[Bug 734093] vaapidecode: allow for per-codec element split

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=734093

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #323544|none                        |needs-work
             status|                            |

--- Comment #20 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 323544:
 --> (https://bugzilla.gnome.org/review?bug=734093&attachment=323544)

::: gst/vaapi/gstvaapidecode.c
@@ +1085,3 @@
 static void
+gst_vaapidecode_base_init (GstVaapiDecodeClass * klass)
+{

If each type is registered individually like you do in the next patch, you can
keep this in class_init. Each type has their own class init (which happens to
be the same function) called.

base_init is only needed if you create deeper inheritance hierarchies.

@@ +1170,3 @@
+  };
+
+  type = g_type_from_name ("vaapidecode");

Type names are like GstVaapiDecode, not vaapidecode

@@ +1171,3 @@
+
+  type = g_type_from_name ("vaapidecode");
+  if (!type) {

Why could it be called multiple times?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.