[Bug 761251] textoverlay: Expose text rendering dimensions to applications and remove absolute positioning limit

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Mar 10 13:55:46 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=761251

--- Comment #22 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 323610
  --> https://bugzilla.gnome.org/attachment.cgi?id=323610
basetextoverlay: Add new position properties for absolute alignment

>+  /**
>+   * GstBaseTextOverlay:xabsolute:
>+   *
>+   * Horizontal position of the rendered text when using positioned alignment.
>+   */
>+  g_object_class_install_property (G_OBJECT_CLASS (klass), PROP_X_ABSOLUTE,
>+      g_param_spec_double ("xabsolute", "horizontal position",
>+          "Horizontal position when using absolute alignment", -G_MAXDOUBLE,
>+          G_MAXDOUBLE, DEFAULT_PROP_XPOS,
>+          G_PARAM_READWRITE | GST_PARAM_CONTROLLABLE | G_PARAM_STATIC_STRINGS));

- "xabsolute" should be "x-absolute" IMHO (I know it's also "xpos" etc., but no
need to continue that bad tradition :))
 - could you add a note what the units are
 - also please add a 'Since: 1.8' at the end
 - gtk-doc chunk text doesn't match GParamSpec text (positioned alignment vs.
absolute alignment)

>+  /**
>+   * GstBaseTextOverlay:yabsolute:
>+   *
>+   * Vertical position of the rendered text when using positioned alignment.
>+   */
>+  g_object_class_install_property (G_OBJECT_CLASS (klass), PROP_Y_ABSOLUTE,
>+      g_param_spec_double ("yabsolute", "vertical position",
>+          "Vertical position when using absolute alignment", -G_MAXDOUBLE,
>           G_MAXDOUBLE, DEFAULT_PROP_YPOS,
>           G_PARAM_READWRITE | GST_PARAM_CONTROLLABLE | G_PARAM_STATIC_STRINGS));

See above

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list