[Bug 763460] videodecoder: events from frames might leak when shutting down

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763460

--- Comment #1 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Created attachment 323631
  --> https://bugzilla.gnome.org/attachment.cgi?id=323631&action=edit
videodecoder: fix events leak

When a frame is released its associated events are transfered to the
'pending_events' list to be pushed with the next frame.

The leak happens because, when shutting down, videodecoder frees its
pending_events lis and then unrefs the pool. By unreffing the pool,
its associated frames are also unreffed and those frames might contain
events that would be added to the pending_events list that won't be
freed again.

We could re-free the pending_events list after unreffing the pool to
make sure those events are freed but, as the pool can have references
elsewhere, it won't guarantee that it is going to be freed at that moment.

Instead, this patch fixes it by adding a boolean to indicate whether the
videodecoder is started or not ( > READY state) and, depending on that,
the events from a released frame are directly freed or added to the
pending_events list.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.