[Bug 753751] Dashdemux: returned seekable range for live streams is not usable

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753751

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #322988|none                        |needs-work
             status|                            |

--- Comment #61 from Edward Hervey <bilboed at bilboed.com> ---
Review of attachment 322988:
 --> (https://bugzilla.gnome.org/review?bug=753751&attachment=322988)

My eyes hurt. Can we make gst_adaptive_demux_stream_download_fragment()
*simpler* and not unreadable like this ?
I'll provide more feedback once I can read it with going cross-eyed :D

::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
@@ +2653,3 @@
   url = stream->fragment.uri;
   GST_DEBUG_OBJECT (stream->pad, "Got url '%s' for stream %p", url, stream);
   if (url) {

switch around the condition.

if (!url)
  goto ...

@@ +2670,3 @@
       /* TODO check if we are truly stopping */
+      live = gst_adaptive_demux_is_live (demux);
+      if (ret == GST_FLOW_CUSTOM_ERROR && live) {

this massive if/else/if/else/if/else... *always* uses "ret ==
GST_FLOW_CUSTOM_ERROR", can we move that check a bit further up ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.