[Bug 763441] rfbsrc: leads to -> invalid video buffer received

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763441

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.dufresne at collabora.
                   |                            |co.uk

--- Comment #7 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
(In reply to Sebastian Dröge (slomo) from comment #6)
> (In reply to Nicolas Dufresne (stormer) from comment #5)
> > Review of attachment 323605 [details] [review] [review]:
> > 
> > ::: gst/librfb/gstrfbsrc.c
> > @@ +370,3 @@
> >    gst_buffer_pool_config_add_option (config,
> > GST_BUFFER_POOL_OPTION_VIDEO_META);
> >  
> > +  return gst_buffer_pool_set_config (pool, config);
> > 
> > Check you return value. This may return FALSE if the configuration had to be
> > changed.
> 
> If the configuration had to be changed, what else than failing can we do? :)

Some changes are acceptable, but need to be communicated (e.g. having infinit
max buffer changed to finit maximum number of buffers). I did port all
decide_allocation I could find. The only exception is when you configure you
own pool, or when we know we are configuring the generic video pool. In that
case, you don't expect it to change anything.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.