[Bug 734093] vaapidecode: allow for per-codec element split

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=734093

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #323688|none                        |accepted-commit_now
             status|                            |

--- Comment #35 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 323688:
 --> (https://bugzilla.gnome.org/review?bug=734093&attachment=323688)

Good to go, just minor memory leak

::: gst/vaapi/gstvaapidecode.c
@@ +1144,3 @@
   /* sink pad */
+  pad_template = gst_pad_template_new ("sink", GST_PAD_SINK, GST_PAD_ALWAYS,
+      gst_caps_from_string (map->caps_str));

The caps returned here need to be unreffed in theory... but are going to be
alive all of the time the application runs anyway. Please fix for correctness

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.