[Bug 762660] flacparse: Pushing buffers before tags

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762660

--- Comment #20 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 322783:
 --> (https://bugzilla.gnome.org/review?bug=762660&attachment=322783)

::: gst/audioparsers/gstflacparse.c
@@ +1718,3 @@
+  if (flacparse->tags) {
+    gst_pad_push_event (GST_BASE_PARSE_SRC_PAD (flacparse),
+        gst_event_new_tag (flacparse->tags));

Why is flacparse pushing tags directly and storing its own tags? Instead of
using the baseparse API for exactly that, which also ensures that tags are
properly merged?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.