[Bug 763553] Not pushing tags before PREROLL

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763553

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Sebastian Dröge (slomo) from comment #2)
> Created attachment 323780 [details] [review]
> baseparse: Recheck after pre_push_frame() if there are tags pending
> 
> Many parsers are storing tags only in pre_push_frame(), if we wouldn't check
> afterwards we would push buffers before those tags and a lot of code assumes
> that tags are available before preroll.

The main problem with this is now that we might push taglists twice. Once a
non-complete one before pre_push_frame(), then a complete one after
pre_push_frame(). I don't see a way to solve this as pre_push_frame() on its
own might already push a buffer via gst_pad_push() and we have no way to
intercept that.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.