[Bug 763553] baseparse: Not pushing tags before PREROLL

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763553

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Let's go with that then for now.

commit 66e9e4c20291b91038a4dc2a112ca04fd6533192
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Sun Mar 13 10:33:13 2016 +0200

    Revert "flacparse: push tags in pre_push_frame"

    This reverts commit 4065fcb80a49924b70f0c8fc159dec0ff47943a1.

    flacparse should not push tags by itself, the base class is going to do
that
    while properly merging in upstream tags. It just didn't because of a bug in
    the base class, which was hidden by this commit.

    https://bugzilla.gnome.org/show_bug.cgi?id=763553


commit 87c0513569b92a34ca325ff1af61f9cbe3b29886
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Sun Mar 13 10:33:53 2016 +0200

    baseparse: Recheck after pre_push_frame() if there are tags pending

    Many parsers are storing tags only in pre_push_frame(), if we wouldn't
check
    afterwards we would push buffers before those tags and a lot of code
assumes that
    tags are available before preroll.

    https://bugzilla.gnome.org/show_bug.cgi?id=763553

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.