[Bug 763491] typefind: behavior has changed on have-type signal, sets pad caps after signal handlers

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Mar 14 11:28:27 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=763491

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #24 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
commit 57bbd18471c7a9f82cf33e2b270e95c73d27910c
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Fri Mar 11 14:17:13 2016 +0200

    typefind: Store caps on the pad before emitting have-type but send it
downstream only in the default signal handler

    https://bugzilla.gnome.org/show_bug.cgi?id=763491


commit 916746e73165ca95a061bc2f975354524c8e3a57
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Sat Mar 12 19:47:47 2016 +0200

    decodebin: expose_pad() is always called with lock==TRUE, simplify code

    This basically reverts ee44337fc3e3030a5155d28b3561af157e6c6003 .

    https://bugzilla.gnome.org/show_bug.cgi?id=763491

commit 65d09c1495ec9093ab95b7539671b48b3c4c9305
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Sat Mar 12 19:46:44 2016 +0200

    decodebin: Don't check twice if the decode chain is complete in
pad_added_cb()

    expose_pad() already does the same.

    https://bugzilla.gnome.org/show_bug.cgi?id=763491

commit 001c7f04a06e261cebd191a541c1f23d13e01022
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Sat Mar 12 19:45:26 2016 +0200

    decodebin: Don't hold EXPOSE_LOCK in type_found() outside the stream lock

    In other places we lock it the other way around, leading to possible
    deadlocks. Also this will deadlock if analyze_pad() causes a new element to
be
    autoplugged that adds new pads on itself when its state is changed.

    https://bugzilla.gnome.org/show_bug.cgi?id=763491

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list